• locuester@lemmy.zip
    link
    fedilink
    English
    arrow-up
    12
    ·
    5 hours ago

    Yeah, we are falling into a little bit of this where I work right now. It’s a bit of a change of mindset to begin thinking that you can’t trust a PR even a little. Yes, you should be able to but humans are humans and we get lazy and trusting the magic pattern machine is gonna impact everyone’s life in a lot of ways

    • BillyClark@piefed.social
      link
      fedilink
      English
      arrow-up
      2
      ·
      60 minutes ago

      It’s a bit of a change of mindset to begin thinking that you can’t trust a PR even a little.

      It has never occurred to me that other people trust PRs, even a little. I mean, that they might think about it in those terms.

      This explains a lot to me.

      Why does it take me longer to review code than other people? They trust the person who wrote it, but I don’t.

      Why is it that when my coworkers think a person is untrustworthy, that they always end up begging me to do all of that person’s reviews. It’s because I’m not bothered by that. I already treat everybody as untrustworthy.

      I’ve never understood how other people think when they do reviews, I guess.

    • Ephera@lemmy.ml
      link
      fedilink
      English
      arrow-up
      3
      ·
      1 hour ago

      That’s really not a good sign, though. A review process to check for basic sanity is just a bandaid fix for a lack of discipline, which ultimately requires more work to be done. So, the person that asked the magic pattern machine should review that code, as they should be deeper into the context of what needs to be done, and they know which parts of the code were generated and which parts they actually logically thought about.