• 22 Posts
  • 1.02K Comments
Joined 3 years ago
cake
Cake day: September 1st, 2023

help-circle





  • This is the type of shit that haunts me. Imagine overloading “>>” for piping and hiding threading behind that. The idea was to create an async pipe, but nowhere are you aware of async or threading or whatever was chosen. You look at the code and think “of it’s like piping to stdout” or whatever, only to find out that the method immediately returns.

    Tracking down what the hell is happening with code that has such hidden side effects is a nightmare.

    Are you still in the C++ world?









  • Like crlf/lf. But for all formatting.

    Sure. Toooootally the same thing. Now the server will have to save a copy of your formatting preferences, checkout the project at point t-1, checkout the project at t, format it, create a diff, and present that to you. Now when you leave a comment on line x, it might be line y for another person.

    Or make it worse, someone introduces malicious code with UTF-8, or switches around parameters, or adds pragma comments that fundamentally change your code, but your formatter happily fixes that for you in the preview so you are oblivious.

    Or you’re hosting this server and someone makes a change that completely reformats the entire codebase, but you see absolutely nothing of it because the preview diff only shows “relevant” changes.

    All fine by you👌







  • Disagree. Linters catch common logic errors, formatters remove nearly all discussions about formatting style. I remember MRs being held up for days at work because of formatting discussions, being resolved by a “style guide” that couldn’t be memorised, and being followed by new discussions about formatting that held MRs.

    The that epitomises this is the nixpkgs repo. There are thousands of PRs stuck in nitpick hell because some particular reviewer wants commas here and another wants them there.