• NocturnalMorning@lemmy.world
    link
    fedilink
    arrow-up
    47
    ·
    4 months ago

    I always try to review the code anyway. There’s no guarantee that what they wrote is doing what you want it to do. Sometimes I find the person was told to do something and didn’t realize it actually needs to do Y and not just X, or visa versa.

    • ScampiLover@lemmy.world
      link
      fedilink
      arrow-up
      20
      ·
      4 months ago

      I like to shoot for the middle ground: skim for key functions and check those, run code locally to see if it does roughly what I think it should do and if it does merge it into dev and see what breaks.

      Small PRs get nitpicked to death since they’re almost certainly around more important code