I wouldn’t say PR size is a bad metric, you usually just need yo read it the opposite of how sloppers do it, i.e. the most productive PRs are short and focused.
Hah, if those pesky devs think that they can play the system by just rolling up the code into a single line they got another thing coming - we’re actually tracking PR character count, NOT LOC like some other companies!
I’m not saying it’s a good individual metric. In fact, applying individual metrics to developers (or most workers really), will only land you in Goodhart’s hell.
But as part of holistic operational health tracking, it’s a useful team level metric, as there is ample evidence that shorter PRs tend to result in less operational issues. And, of course, this is only valid if you don’t try to tie financial rewards to it, otherwise people will forget that PR size is a proxy measure for how easy changes are to review and rollback.
I wouldn’t say PR size is a bad metric, you usually just need yo read it the opposite of how sloppers do it, i.e. the most productive PRs are short and focused.
PR size is an awful metric. The bigger the PR, the less reviewable it is.
Yes, that’s what the comment said — smaller PRs are better.
Then Devs focus on minifying the code into an unreadable mess
Hah, if those pesky devs think that they can play the system by just rolling up the code into a single line they got another thing coming - we’re actually tracking PR character count, NOT LOC like some other companies!
I’m not saying it’s a good individual metric. In fact, applying individual metrics to developers (or most workers really), will only land you in Goodhart’s hell.
But as part of holistic operational health tracking, it’s a useful team level metric, as there is ample evidence that shorter PRs tend to result in less operational issues. And, of course, this is only valid if you don’t try to tie financial rewards to it, otherwise people will forget that PR size is a proxy measure for how easy changes are to review and rollback.
deleted by creator