• Clay_pidgin@sh.itjust.works
    link
    fedilink
    English
    arrow-up
    1
    ·
    8 hours ago

    I always feel bad about putting little ifs at the top of functions. Is it not bad practice? I like them because they’re simple to implement modify and read, but I have this voice telling me I need to make things more impressive.

    • Lightfire228@pawb.social
      link
      fedilink
      arrow-up
      2
      ·
      2 hours ago

      Never make things more “impressive”

      Make them more comprehensible

      Reduce the cognitive load required to understand and reason about a piece of code. Honestly, the more you can express complicated ideas simply, the more impressive you are

    • Jankatarch@lemmy.world
      link
      fedilink
      arrow-up
      2
      ·
      edit-2
      6 hours ago

      I started putting a helpful comment above the ifs as a seperator to cope with that.

      public Value? Func(String arg) { 
        // Sanitize.
        if (arg.IsEmpty()) return null; 
        if (this.Bar == null) return null; 
        // Get [that] and/or do [this].
        var foo = this.baz.foo;
        ...
        return new Value();
      }