Tony Bark@pawb.social to Linux@lemmy.world · edit-21 month agoTorvalds blasts kernel dev for late 'garbage' RISC-V patcheswww.theregister.comexternal-linkmessage-square13fedilinkarrow-up173arrow-down17
arrow-up166arrow-down1external-linkTorvalds blasts kernel dev for late 'garbage' RISC-V patcheswww.theregister.comTony Bark@pawb.social to Linux@lemmy.world · edit-21 month agomessage-square13fedilink
minus-squareVeryFrugal@sh.itjust.workslinkfedilinkEnglisharrow-up12·1 month ago Like this crazy and pointless make_u32_from_two_u16() ‘helper’. That thing makes the world actively a worse place to live. I love how enthusiastic he is about make_u32_from_two_u16()
minus-squaresquaresinger@lemmy.worldlinkfedilinkEnglisharrow-up7·1 month agoIt really is kinda hard to justify wrapping a << 16 | b in a function.
minus-squareTheTechnician27@lemmy.worldlinkfedilinkEnglisharrow-up3·edit-21 month agoEspecially given that one actually tells you where the values get placed.
minus-squareMysteriousSophon21@lemmy.worldlinkfedilinkEnglisharrow-up2·1 month agoYep, these kind of wrapper functions actually hurt kernel readability and add unecessary call overhead - in critical kernel paths every instruction counts.
I love how enthusiastic he is about
make_u32_from_two_u16()It really is kinda hard to justify wrapping
a << 16 | bin a function.Especially given that one actually tells you where the values get placed.
Yep, these kind of wrapper functions actually hurt kernel readability and add unecessary call overhead - in critical kernel paths every instruction counts.